Allow to use quelpa-use-package as source of truth for quelpa-cache#26
Allow to use quelpa-use-package as source of truth for quelpa-cache#26kiennq wants to merge 2 commits intoquelpa:masterfrom
Conversation
alphapapa
left a comment
There was a problem hiding this comment.
I've left some comments on individual lines. Beyond those, please write a bit about the purpose of this PR and why it's necessary, to help me understand it.
quelpa-use-package.el
Outdated
| (defvar quelpa-use-package-inhibit-loading-quelpa nil | ||
| (defgroup quelpa-use-package nil | ||
| "Quelpa handler for `use-package'." | ||
| :prefix "quelpa-use-package" |
There was a problem hiding this comment.
It's not harmful to specify the prefix, but it's unnecessary for options specified later in the same file.
| :group 'use-package) | ||
|
|
||
| (defcustom quelpa-use-package-inhibit-loading-quelpa nil | ||
| "If non-nil, `quelpa-use-package' will do its best to avoid |
There was a problem hiding this comment.
The first line of a docstring should be a complete sentence. If this one's is being updated, it might as well be fixed.
| :type 'boolean | ||
| :group 'quelpa-use-package) | ||
|
|
||
| (defcustom quelpa-use-package-as-source-of-truth nil |
There was a problem hiding this comment.
The name of this variable seems unclear, and a bit mysterious. Could it be given a more descriptive one?
Thanks, let me clarify the purpose of this PR before addressing your comments. So, if we don't install any new package with Since we have this |
5410bb6 to
5cd28b7
Compare
This allows the
quelpa-cacheto be populated from the usage ofquelpa-use-packageonly.Since we're using
quelpa-cacheas a way to indicate which packages are managed byquelpa, this change allows those packages are correctly populated via the config files only.Also using a simpler form instead of
package-installed-pto check for package availability so that we don't need to load the wholepackagepackage when running from init file, improve Emacs init time