Add mobile sync session wiring#3574
Conversation
| ) | ||
| private val driverFactory = DriverFactory(context = applicationContext) | ||
|
|
||
| private val graph by lazy { SharedDependencyGraph.init(driverFactory, environment) } |
There was a problem hiding this comment.
we need to call the one that takes in the AuthEnvironment otherwise we always get the default which is always production because:
return if (BuildKonfig.IS_DEBUG) AuthEnvironment.PRELIVE else AuthEnvironment.PRODUCTIONand because we publish release artifacts as we should do.
| val syncService: SyncService | ||
| get() = graph.syncService | ||
|
|
||
| private fun endpoint(context: Context): String { |
There was a problem hiding this comment.
for now, instead of using the debuggable flag, let's use the package name - if it ends with .debug use prelive otherwise production - in the future we should probably put this behind an interface
AhmedNMahran
force-pushed
the
feature/wire-mobile-sync-dependency
branch
from
1b2a537 to
fb85bdd
Compare
|
@ahmedre I've minimized the PR scope to just add the dependency. please check |
Head branch was pushed to by a user without write access
| android:requestLegacyExternalStorage="true" | ||
| android:enableOnBackInvokedCallback="true" | ||
| android:localeConfig="@xml/locales_config" | ||
| tools:replace="android:fullBackupContent,android:dataExtractionRules" |
There was a problem hiding this comment.
wait, why are we adding this? 🤔
There was a problem hiding this comment.
can we open an issue for their repo and/or a pull request to change this and explain why?
|
|
New Dependencies Upgraded Dependencies |
2 participants
Summary
common:bookmarkMobileSyncSessionwrapper aroundSharedDependencyGraphNotes