fix: rotate oversized session files to prevent container timeouts#928
Open
kianwoon wants to merge 3 commits intoqwibitai:mainfrom
Open
fix: rotate oversized session files to prevent container timeouts#928kianwoon wants to merge 3 commits intoqwibitai:mainfrom
kianwoon wants to merge 3 commits intoqwibitai:mainfrom
Conversation
- Add session file size check before spawning container - Rotate to new session ID when file exceeds 5 MB threshold - Old session files are preserved (not deleted) - Fixes qwibitai#697 Co-authored-by: Kian Woon <wiserly@hotmail.com>
Andy-NanoClaw-AI
added
PR: Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #697
Session conversation logs stored as JSONL files grow unbounded. When a session file exceeds ~5 MB, the container agent takes too long to load it on startup, causing timeouts and failed agent invocations.
Changes
maybeRotateSession()function to check session file size before spawning containerImpact