ud_convert has side effects

[Enchufa2]

I always insist in my classes to avoid this and yet... :(

x <- 0.1
units::ud_convert(x, "m", "cm")
#> [1] 10
x
#> [1] 10

[Enchufa2]

And not sure why, but this may have weird consequences when testthat is involved (see e.g. nlmixr2/babelmixr2/pull/153). It may be due to the magic they do to capture stuff and so on.

[edzer]

Oh lovely, we forgot to make a deep copy...

[Enchufa2]

Oh lovely, we forgot to make a deep copy...

Exactly. It was an internal function, so we avoided making copies. But now that it's exported, we need to be more careful.