Skip to content

Use default pillar_shaft() method for numbers#273

Merged
Enchufa2 merged 6 commits intor-quantities:masterfrom
krlmlr:f-pillar
Mar 16, 2021
Merged

Use default pillar_shaft() method for numbers#273
Enchufa2 merged 6 commits intor-quantities:masterfrom
krlmlr:f-pillar

Conversation

@krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Mar 16, 2021

This gives underlines for every other block of three digits, and all the other details of default pillar formatting.

Working on making formatting customizable, see https://pillar.r-lib.org/dev/articles/numbers.html for a primer. When merged, units will also benefit.

CC @lionel-.

Includes part of #274.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #273 (7ac8a80) into master (3e451b3) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   94.29%   94.40%   +0.10%     
==========================================
  Files          18       18              
  Lines         877      876       -1     
==========================================
  Hits          827      827              
+ Misses         50       49       -1     
Impacted Files Coverage Δ
R/conversion.R 88.23% <ø> (ø)
R/tidyverse.R 96.42% <100.00%> (+3.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e451b3...ec8ff07. Read the comment docs.

@Enchufa2
Copy link
Member

LGTM. Thanks!

@Enchufa2 Enchufa2 merged commit 70bcb76 into r-quantities:master Mar 16, 2021
@krlmlr krlmlr mentioned this pull request Mar 17, 2021
@krlmlr krlmlr deleted the f-pillar branch December 25, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants