Skip to content

Keep pillar attribute in vec_restore()#280

Merged
Enchufa2 merged 3 commits intor-quantities:masterfrom
krlmlr:f-restore-units
Apr 3, 2021
Merged

Keep pillar attribute in vec_restore()#280
Enchufa2 merged 3 commits intor-quantities:masterfrom
krlmlr:f-restore-units

Conversation

@krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Apr 3, 2021

Required for vec_slice(). Follow-up to #275.

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #280 (541d2d1) into master (e215530) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 541d2d1 differs from pull request most recent head e0b7058. Consider uploading reports for the commit e0b7058 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          18       18           
  Lines         877      877           
=======================================
  Hits          828      828           
  Misses         49       49           
Impacted Files Coverage Δ
R/make_units.R 89.83% <ø> (-0.26%) ⬇️
R/tidyverse.R 96.77% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e215530...e0b7058. Read the comment docs.

@krlmlr krlmlr mentioned this pull request Apr 3, 2021
@krlmlr
Copy link
Contributor Author

krlmlr commented Apr 3, 2021

macOS devel doesn't have binaries for udunits2, otherwise builds look good.

@krlmlr
Copy link
Contributor Author

krlmlr commented Apr 3, 2021

See https://pillar.r-lib.org/dev/articles/numbers.html#units for a demo, I quite like it! We can set display options on a units object, it survives arithmetics.

@Enchufa2
Copy link
Member

Enchufa2 commented Apr 3, 2021

Could you please rebase/merge current master? I've added a workflow to check quantities on PR.

@Enchufa2
Copy link
Member

Enchufa2 commented Apr 3, 2021

All good, thanks!

@Enchufa2 Enchufa2 merged commit c59344d into r-quantities:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants