Conversation
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 94.42% 93.12% -1.31%
==========================================
Files 18 18
Lines 879 858 -21
==========================================
- Hits 830 799 -31
- Misses 49 59 +10
Continue to review full report at Codecov.
|
Member
Author
|
Codecov complains, but the few lines without coverage are on purpose. |
Member
Author
|
@edzer Kind reminder. :) Did you have time to take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before tackling #289, I realized that unit mapping was not entirely correct: we were mapping symbols/names to units, but not units to symbol/names, and apparently both are required. This PR solves this.
I've also cleaned up the C interface by distinguishing two kinds of functions:
R_<udunits2_name>, e.g.,R_ut_parse.ud_<something>, e.g.,ud_convert.Finally, I've removed deprecated functions and created a man page specifically to document all the defunct ones.