Skip to content

Use floor() instead of round() in %%#365

Merged
Enchufa2 merged 2 commits intor-quantities:mainfrom
UchidaMizuki:fix-arith-#364
Feb 21, 2024
Merged

Use floor() instead of round() in %%#365
Enchufa2 merged 2 commits intor-quantities:mainfrom
UchidaMizuki:fix-arith-#364

Conversation

@UchidaMizuki
Copy link
Contributor

Fix #364.
I have enhanced tests for %% to make sure it behaves correctly.

@codecov
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f56521c) 91.54% compared to head (6ee538e) 91.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   91.54%   91.58%   +0.03%     
==========================================
  Files          19       19              
  Lines         994      998       +4     
==========================================
+ Hits          910      914       +4     
  Misses         84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Enchufa2
Copy link
Member

Good catch, thanks!

@Enchufa2 Enchufa2 merged commit 23751a7 into r-quantities:main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

%% doesn't work correctly due to rounding

2 participants