Fixing rethrown exceptions to properly preserve stackframes.#850
Merged
michaelklishin merged 1 commit intorabbitmq:masterfrom May 26, 2020
Merged
Fixing rethrown exceptions to properly preserve stackframes.#850michaelklishin merged 1 commit intorabbitmq:masterfrom
michaelklishin merged 1 commit intorabbitmq:masterfrom
Conversation
michaelklishin
approved these changes
May 26, 2020
michaelklishin
added a commit
that referenced
this pull request
May 26, 2020
Fixing rethrown exceptions to properly preserve stackframes. (cherry picked from commit 81cfa56)
Contributor
|
Backported to |
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
This was referenced Aug 17, 2025
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
This was referenced Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR fixes those cases where exceptions were rethrown in a way that polluted the stackframes, making debugging/troubleshooting harder.
This is in line with the .NET guidelines on rethrowing exceptions:
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2200?view=vs-2019
https://docs.microsoft.com/en-us/archive/msdn-magazine/2015/november/essential-net-csharp-exception-handling#throwing-existing-exceptions-without-replacing-stack-information
Types of Changes
Checklist
CONTRIBUTING.mddocument