Fix JSON output for rad app graph command by nellshamrell · Pull Request #11207 · radius-project/radius

nellshamrell · 2026-02-09T22:55:39Z

Allows rad app graph command to output json

(Please note I am very new to Go development and welcome feedback on things I can improve!)

Description

Fixes bug where rad app graph -o json was not outputting json.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required). (Not necessarily approved, but I filed issue rad app graph -o json is not outputting json #11205 before filing this pull request)

Fixes: #11205

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

Allows rad app graph command to output json Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>

Copilot

Pull request overview

Enables rad app graph to honor -o json by adding the shared output flag and emitting structured output for JSON format, aligning the command with other CLI commands that support --output.

Changes:

Add --output/-o support to rad app graph and plumb the selected format into the runner.
When -o json is selected, write the raw ApplicationGraphResponse via WriteFormatted.
Add a unit test covering JSON output behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
pkg/cli/cmd/app/graph/graph.go	Adds output flag support and JSON formatted output path for `rad app graph`.
pkg/cli/cmd/app/graph/graph_test.go	Adds a new test ensuring JSON format uses `WriteFormatted`.

Copilot · 2026-02-10T01:47:20Z

pkg/cli/cmd/app/graph/graph.go

+	format, err := cli.RequireOutput(cmd)
+	if err != nil {
+		return err
+	}
+	r.Format = format
+


The output format read from the flag is never validated/normalized. If a user passes an unsupported value (or a different casing like -o JSON), Run() will silently fall back to the table-style display instead of returning an error / emitting JSON. Normalize the flag value (trim/lowercase) and validate it against output.SupportedFormats() (or use output.NewFormatter for validation) during Validate(), then switch on the normalized value in Run().

@copilot open a new pull request to apply changes based on this feedback

brooke-hamilton

Only one nit: please update the PR title to something descriptive like "Fix JSON output for rad app graph command"

The rad app graph -o json command works well:

$ rad app graph --output json | jq
{
  "resources": [
    {
      "connections": [],
      "id": "/planes/radius/local/resourcegroups/default/providers/Applications.Core/containers/demo",
      "name": "demo",
      "outputResources": [
        {
          "id": "/planes/kubernetes/local/namespaces/default-testfix/providers/apps/Deployment/demo",
          "name": "demo",
          "type": "apps/Deployment"
        },
        {
          "id": "/planes/kubernetes/local/namespaces/default-testfix/providers/core/Service/demo",
          "name": "demo",
          "type": "core/Service"
        },
        {
          "id": "/planes/kubernetes/local/namespaces/default-testfix/providers/core/ServiceAccount/demo",
          "name": "demo",
          "type": "core/ServiceAccount"
        },
        {
          "id": "/planes/kubernetes/local/namespaces/default-testfix/providers/rbac.authorization.k8s.io/Role/demo",
          "name": "demo",
          "type": "rbac.authorization.k8s.io/Role"
        },
        {
          "id": "/planes/kubernetes/local/namespaces/default-testfix/providers/rbac.authorization.k8s.io/RoleBinding/demo",
          "name": "demo",
          "type": "rbac.authorization.k8s.io/RoleBinding"
        }
      ],
      "provisioningState": "Succeeded",
      "type": "Applications.Core/containers"
    }
  ]
}

brooke-hamilton · 2026-02-10T17:52:13Z

pkg/cli/cmd/app/graph/graph.go

+		return err
+	}
+	r.Format = format
+


+1 to what Copilot said: the format command falls back to text when the output is invalid. Other commands validate the input. Here's an example:

# This command fails silently. $ rad app graph --output banana Displaying application: testfix Name: demo (Applications.Core/containers) Connections: (none) Resources: demo (apps/Deployment) demo (core/Service) demo (core/ServiceAccount) demo (rbac.authorization.k8s.io/Role) demo (rbac.authorization.k8s.io/RoleBinding) # This command fails as expected. $ rad app list --output banana Error: unsupported format banana TraceId: a44b8eb4a8f8aa693d96b8ffae79d59f

$ rad app graph -o banana unsupported output format "banana", supported formats are: json, table, plain-text

nellshamrell · 2026-02-10T19:06:16Z

@copilot open a new pull request to apply changes based on the comments in this thread

Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>

brooke-hamilton

🚢

radius-functional-tests · 2026-02-11T18:36:13Z

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details

Name	Value
Repository	nellshamrell/radius
Commit ref	`313affc`
Unique ID	funceea31b1714
Image tag	pr-funceea31b1714

gotestsum 1.13.0
KinD: v0.29.0
Dapr: 1.14.4
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funceea31b1714
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funceea31b1714
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funceea31b1714
controller test image location: ghcr.io/radius-project/dev/controller:pr-funceea31b1714
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funceea31b1714
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Allows rad app graph command to output json (Please note I am very new to Go development and welcome feedback on things I can improve!) # Description Fixes bug where `rad app graph -o json` was not outputting json. ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). (Not necessarily approved, but I filed issue #11205 before filing this pull request)  Fixes: #11205 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable:  - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes  - [x] Not applicable  - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes  - [x] Not applicable  - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes  - [x] Not applicable  - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes  - [x] Not applicable  - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes  - [x] Not applicable  - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes  - [x] Not applicable  --------- Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>

Allows rad app graph command to output json (Please note I am very new to Go development and welcome feedback on things I can improve!) # Description Fixes bug where `rad app graph -o json` was not outputting json. ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). (Not necessarily approved, but I filed issue #11205 before filing this pull request)  Fixes: #11205 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable:  - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes  - [x] Not applicable  - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes  - [x] Not applicable  - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes  - [x] Not applicable  - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes  - [x] Not applicable  - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes  - [x] Not applicable  - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes  - [x] Not applicable  --------- Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

Fixes radius-project#11205

70a411a

Allows rad app graph command to output json Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>

nellshamrell requested review from a team as code owners February 9, 2026 22:55

nellshamrell temporarily deployed to external-contributor-approval February 9, 2026 22:55 — with GitHub Actions Inactive

nellshamrell temporarily deployed to publish-bicep February 10, 2026 00:59 — with GitHub Actions Inactive

brooke-hamilton requested a review from Copilot February 10, 2026 01:36

Copilot started reviewing on behalf of brooke-hamilton February 10, 2026 01:37 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

brooke-hamilton requested changes Feb 10, 2026

View reviewed changes

nellshamrell changed the title ~~Fixes #11205~~ Fix JSON output for rad app graph command Feb 10, 2026

adds normalization and validation to cli flags

e0c0fe0

Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>

nellshamrell temporarily deployed to external-contributor-approval February 11, 2026 00:23 — with GitHub Actions Inactive

nellshamrell temporarily deployed to publish-bicep February 11, 2026 00:23 — with GitHub Actions Inactive

brooke-hamilton approved these changes Feb 11, 2026

View reviewed changes

Merge branch 'main' into app-graph-json-fix

5e1caf0

nellshamrell temporarily deployed to external-contributor-approval February 11, 2026 16:56 — with GitHub Actions Inactive

nellshamrell temporarily deployed to publish-bicep February 11, 2026 17:03 — with GitHub Actions Inactive

Merge branch 'main' into app-graph-json-fix

313affc

brooke-hamilton temporarily deployed to external-contributor-approval February 11, 2026 18:34 — with GitHub Actions Inactive

brooke-hamilton temporarily deployed to publish-bicep February 11, 2026 18:36 — with GitHub Actions Inactive

brooke-hamilton merged commit 1dbbb57 into radius-project:main Feb 11, 2026
50 checks passed

nellshamrell mentioned this pull request Mar 24, 2026

REQUEST: New membership for nellshamrell radius-project/community#109

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix JSON output for rad app graph command#11207

Fix JSON output for rad app graph command#11207
brooke-hamilton merged 4 commits intoradius-project:mainfrom
nellshamrell:app-graph-json-fix

nellshamrell commented Feb 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

nellshamrell Feb 10, 2026

Uh oh!

brooke-hamilton left a comment

Uh oh!

brooke-hamilton Feb 10, 2026

Uh oh!

nellshamrell Feb 10, 2026

Uh oh!

nellshamrell Feb 11, 2026

Uh oh!

nellshamrell Feb 11, 2026

Uh oh!

nellshamrell commented Feb 10, 2026

Uh oh!

brooke-hamilton left a comment

Uh oh!

radius-functional-tests bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nellshamrell commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Contributor checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

nellshamrell Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

brooke-hamilton left a comment

Choose a reason for hiding this comment

Uh oh!

brooke-hamilton Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

nellshamrell Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

nellshamrell Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

nellshamrell Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

nellshamrell commented Feb 10, 2026

Uh oh!

brooke-hamilton left a comment

Choose a reason for hiding this comment

Uh oh!

radius-functional-tests bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nellshamrell commented Feb 9, 2026 •

edited

Loading

radius-functional-tests bot commented Feb 11, 2026 •

edited

Loading