refactor: omit id prop in dialog description and title#3584
Open
nayounsang wants to merge 2 commits intoradix-ui:mainfrom
Open
refactor: omit id prop in dialog description and title#3584nayounsang wants to merge 2 commits intoradix-ui:mainfrom
nayounsang wants to merge 2 commits intoradix-ui:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c914370 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
related to #3579
In the current accessibility verification algorithm, there is no way to verify when a user uses a custom id. Therefore, as a convention, we do not allow IDs to be specified in Title and Description.
If we want to enable custom ids,we should only fetch the id via ref and validate it. So the Provider's code will change somewhat.
The simple way right now is to discourage writing ids via types.