Skip to content

Support parrent matching of GlobalID & GlobalID::URI#140

Merged
dhh merged 1 commit intorails:mainfrom
ojab:pattern_matching
Dec 16, 2022
Merged

Support parrent matching of GlobalID & GlobalID::URI#140
dhh merged 1 commit intorails:mainfrom
ojab:pattern_matching

Conversation

@ojab
Copy link
Contributor

@ojab ojab commented Mar 30, 2022

IMHO would be handy to use it in locators, something like

case gid
in app: 'AppOne', model_name: 'ModelOne'
  AppOneModelOneLocator.call(gid.model_id)
in app: 'AppTwo'
  AppTwoLocator.call(gid.model_name, gid.model_id)
else
  # /shrug
end

@ojab ojab force-pushed the pattern_matching branch 3 times, most recently from 1792db2 to 5ba4bea Compare March 30, 2022 19:25
@ojab ojab marked this pull request as ready for review March 30, 2022 19:36
@ojab ojab force-pushed the pattern_matching branch from 5ba4bea to 4e3a459 Compare March 30, 2022 20:33
@ojab ojab force-pushed the pattern_matching branch from 4e3a459 to 2bfdb05 Compare March 30, 2022 22:00
@ojab
Copy link
Contributor Author

ojab commented Oct 26, 2022

ping?

@dhh dhh merged commit fa6058a into rails:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ojab @dhh