URI::GID: Update #check_scheme, no need to call super#146
Merged
rafaelfranca merged 1 commit intorails:mainfrom Aug 5, 2022
Merged
URI::GID: Update #check_scheme, no need to call super#146rafaelfranca merged 1 commit intorails:mainfrom
rafaelfranca merged 1 commit intorails:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When instantiating a
GlobalId, the scheme has to be validated withcheck_scheme. Currently anything other than"gid"is invalid, and then if the string used is exactly"gid"we callsuperwhich ends up running some Regex inURI::Generic#check_scheme.This PR is a small optimization - I don't think we need to call
check_scheme, shouldn't"gid"always pass?Here's the method in
URI::Generic: https://github.com/ruby/ruby/blob/1e7a2415a4c69aa64c9c2a561197bf9cfc5a91f8/lib/uri/generic.rb#L320-L324