Don't break on models where primary_key is not defined#168
Merged
eileencodes merged 1 commit intorails:mainfrom Sep 5, 2023
Merged
Don't break on models where primary_key is not defined#168eileencodes merged 1 commit intorails:mainfrom
primary_key is not defined#168eileencodes merged 1 commit intorails:mainfrom
Conversation
ghiculescu
force-pushed
the
handle-no-primary-key
branch
from
2051832 to
759d1eb
Compare
This was referenced Sep 4, 2023
Contributor
adrianna-chang-shopify
left a comment
adrianna-chang-shopify
left a comment
There was a problem hiding this comment.
Thanks @ghiculescu , this definitely seems like a fairer compromise 🙇♀️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#163 introduced these errors into Rails CI: https://buildkite.com/rails/rails/builds/99322#018a5d7e-f556-4966-a32d-904737c65eeb
They are occuring on classes that
include GlobalID::Identificationbut are not Active Record subclasses.There is no explicit GlobalID API identified, but as far as I can tell, the only methods you need to implement are
self.find,self.where, andid. So this PR ensures that we don't break support for classes that don't implementprimary_key.