Skip to content

Ensure that Jbuilder.encode properly forwards arguments to .new #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaelfranca merged 1 commit into from
Aug 12, 2025
Merged

Ensure that Jbuilder.encode properly forwards arguments to .new #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/jbuilder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ def initialize(
end

# Yields a builder and automatically turns the result into a JSON string
def self.encode(*args, &block)
new(*args, &block).target!
def self.encode(...)
new(...).target!
end

BLANK = Blank.new
Expand Down
7 changes: 7 additions & 0 deletions test/jbuilder_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,4 +936,11 @@ class JbuilderTest < ActiveSupport::TestCase
result = JSON.load(Jbuilder.encode { |json| json.time Time.parse("2018-05-13 11:51:00.485 -0400") })
assert_equal "2018-05-13T11:51:00.485-04:00", result["time"]
end

test "encode forwards options to new" do
Jbuilder.encode(key_formatter: 1, ignore_nil: 2) do |json|
assert_equal 1, json.instance_eval{ @key_formatter }
assert_equal 2, json.instance_eval{ @ignore_nil }
end
end
end