Fix musepack files application/vnd.mophun.certificate -> audio/mpc #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy-H-Nguyen
changed the title
Andy-H-Nguyen
force-pushed
the
fix-musepack
branch
from
637196d to
834d8dd
Compare
Andy-H-Nguyen
changed the title
gmcgibbon
reviewed
May 31, 2021
Member
gmcgibbon
left a comment
gmcgibbon
left a comment
There was a problem hiding this comment.
Could you please add the fixture to the magic folder also to generate a magic test too? Thanks!
Andy-H-Nguyen
force-pushed
the
fix-musepack
branch
from
834d8dd to
f7182ff
Compare
gmcgibbon
approved these changes
Jun 1, 2021
Member
gmcgibbon
left a comment
gmcgibbon
left a comment
There was a problem hiding this comment.
Thanks. LGTM after the line change!
lib/marcel/mime_type/definitions.rb
Outdated
|
|
||
| Marcel::MimeType.extend "audio/flac", magic: [[0, 'fLaC']], extensions: %w( flac ), parents: "audio/x-flac" | ||
| Marcel::MimeType.extend "audio/x-wav", magic: [[0, 'RIFF', [[8, 'WAVE']]]], extensions: %w( wav ), parents: "audio/vnd.wav" | ||
| Marcel::MimeType.extend "audio/mpc", magic: [[0, "MPCKSH"]], extensions: %w( mpc ), parents: "application/vnd.mophun.certificate" |
Member
There was a problem hiding this comment.
Suggested change
| Marcel::MimeType.extend "audio/mpc", magic: [[0, "MPCKSH"]], extensions: %w( mpc ), parents: "application/vnd.mophun.certificate" | |
| Marcel::MimeType.extend "audio/mpc", magic: [[0, "MPCKSH"]], extensions: %w( mpc ) |
The parent type here isn't actually related to the one we're overriding with.
Andy-H-Nguyen
force-pushed
the
fix-musepack
branch
from
f7182ff to
b7af44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in issue #48. There's been an error in the classification of musepack audio files. Note that in v0.3.3 this was classified as audio/x-musepack. There is no exact definition for MPC in https://www.iana.org/assignments/media-types/media-types.xhtml. But audio/mpc bests follows the type-reporting format of the existing types.
Files in the fixture are self-recorded, and is OK to use in our fixtures.