Adds note to README.md regarding CSS bundling issues on vendored libs #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From version 0.5.0 to 0.6.0, `bulma.min.css` was vendored into the lib instead of linking to the CDN version to better conform to the content security policy. Unfortunately, when passing through a common older CSS bundler (sass-rails) during `rails assets:precompile`, that CSS doesn't seem to pass muster: ``` SassC::SyntaxError: Error: Invalid CSS after "...--s),var(--l));": expected "}", was "--00-l:var(--bulma-" (SassC::SyntaxError) ``` I assume Bulma is using some feature of DartSass/CSS that `sass-rails` and `sassc-rails` do not support. Updating the CSS bundler to `dartsass-rails` fixes the issue.
Member
|
Ohh, great catch, explanation and change! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From version 0.5.0 to 0.6.0,
bulma.min.csswas vendored into the lib instead of linking to the CDN version to better conform to the content security policy.Unfortunately, when passing through a common older CSS bundler (sass-rails) during
rails assets:precompile, that CSS doesn't seem to pass muster:I assume Bulma is using some feature of DartSass/CSS that
sass-railsandsassc-railsdo not support. Updating the CSS bundler todartsass-railsfixes the issue.