Skip to content

Do not create a new transaction when creating a ReadyExecution #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leondmello wants to merge 2 commits into from
Closed

Do not create a new transaction when creating a ReadyExecution #424

leondmello wants to merge 2 commits into from

Conversation

@leondmello
Copy link

@leondmello leondmello commented Nov 21, 2024

Fixes #421

@leondmello
Copy link
Author

leondmello commented Nov 21, 2024

@rosa Does this line need the same change?

solid_queue/app/models/solid_queue/job/schedulable.rb

Line 40 in 393e3b9

ScheduledExecution.create_or_find_by!(job_id: id)

@rosa
Copy link
Member

rosa commented Nov 22, 2024

Closing per #421 (comment).

@rosa rosa closed this Nov 22, 2024
@leondmello leondmello deleted the patch-1 branch November 22, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Jobs and transactional integrity docs don't seem to be what actually happens in Solid Queue when using a single DB

2 participants

@leondmello @rosa