Closed
Conversation
Contributor
Author
|
Hopefully I've correctly updated |
Contributor
Author
|
@ramosbugs bump, any blockers for this to be merged? |
Owner
|
does this require every WASM build to set |
Contributor
Author
|
Unfortunately yes, I'll remove the |
Contributor
Author
|
Apparently neither can |
|
Does adding the following to [target.wasm32-unknown-unknown]
# The dependency getrandom needs this flag set, but only when the target is wasm32-unknown-unknown.
# https://docs.rs/getrandom/latest/getrandom/#opt-in-backends
rustflags = ['--cfg', 'getrandom_backend="wasm_js"'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: This PR originally went to update
getrandomtoo, but that includes a wasm breaking change and can be done in a major version only.Updates
randfrom0.8to0.9and.getrandomfrom0.2to0.3The
randupdate included some deprecations, I've replaced them.Thegetrandomupdate renamed thejsfeature towasm_js.I'd like this to be merged as I currently use other crates that are on the newer versions (and this one adds duplicated deps).