RFC: Bump ureq version and update SyncHttpClient implementation for ureq::Agent#338
Open
winstonallo wants to merge 2 commits intoramosbugs:mainfrom
Open
RFC: Bump ureq version and update SyncHttpClient implementation for ureq::Agent#338winstonallo wants to merge 2 commits intoramosbugs:mainfrom
ureq version and update SyncHttpClient implementation for ureq::Agent#338winstonallo wants to merge 2 commits intoramosbugs:mainfrom
Conversation
winstonallo
changed the title
ureq version and update SyncHttpClient implementation for ureq::Agentureq version and update SyncHttpClient implementation for ureq::Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
when trying to use the
ureqbackend foroauth2, I unfortunately had to find out that while it is documented as a feature in the crate docs, it is no longer available in the Debian-packaged version of the crate, since Debian only packages ureq 3, and oauth2 depends on ureq 2.We patched this on our side by implementing the
SyncHttpClienttrait for a newtype overureq::Agent, so I thought it would make sense to propose those changes here in case someone else needs this too.We needed the
platform-verifierfeature fromureqto avoid running into this panic. I guess it could also be made optional, happy to iterate on this if you need me to!