chore: remove plugin system divergence with upstream#392
Merged
Conversation
Restores 6 deleted files and updates 3 modified files to match anomalyco/dev: - Restored: cloudflare.ts, install.ts, loader.ts, meta.ts, shared.ts, github-copilot/models.ts - Updated: index.ts, codex.ts, github-copilot/copilot.ts Total: +1941 lines, -138 lines across 9 files Fixes #391
Added stub modules and utilities to support upstream plugin files: - Created: util/error.ts, util/filesystem.ts extensions, util/flock.ts, util/record.ts - Created: effect/instance-state.ts, effect/run-service.ts stubs - Created: config/paths.ts, npm.ts stubs - Updated: bus/index.ts, config/config.ts, flag/flag.ts, server/server.ts - Simplified: plugin/index.ts, plugin/github-copilot/copilot.ts, plugin/shared.ts Typecheck: PASS Tests: 1491 pass, 6 fail (expected - plugin tests written for Effect-based system) Part of #391
Documents that flock stub is no-op and may have race conditions. Addresses adversarial review feedback on PR #392.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #391