Add option to configure SentenceBoundary#348
Merged
rany2 merged 2 commits intorany2:masterfrom Aug 5, 2025
Merged
Conversation
Owner
|
I'm not sure if this is the right approach to the problem. My concern is that sentence boundary is deprecated on Azure Cognitive Services and Microsoft Edge browser doesn't set it. This might cause the library to be banned when this option is set. |
rany2
changed the title
Owner
|
Thanks! I changed my mind about this. Worst case scenario we remove the functionality if Microsoft blocks it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add setence boundary which is more friendly to Chinese users
I resubmit a new PR to FIX code style check issues in the previous PR