[PLGN-634] InsightVM - Asset Search | JsonDecode Error#2185
Merged
cmcnally-r7 merged 3 commits intodevelopfrom Dec 13, 2023
Merged
[PLGN-634] InsightVM - Asset Search | JsonDecode Error#2185cmcnally-r7 merged 3 commits intodevelopfrom
cmcnally-r7 merged 3 commits intodevelopfrom
Conversation
23f7018 to
5dc9e6c
Compare
igorski-r7
reviewed
Dec 13, 2023
12a29c0 to
43f802c
Compare
43f802c to
f655a7b
Compare
rbowden-r7
approved these changes
Dec 13, 2023
cmcnally-r7
added a commit
that referenced
this pull request
Dec 13, 2023
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
cmcnally-r7
added a commit
that referenced
this pull request
Dec 13, 2023
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
joneill-r7
pushed a commit
that referenced
this pull request
Dec 14, 2023
* [PLGN-561] Insight VM - Scan Completion Trigger (#2087) * Init commit - Simple connection test refactor * Spec mapped draft * Add new trigger outline * Trigger template * Fix snyk | Succesful scan API call | manifest fixed for new trigger * Save point #1 * Save point #2 * Map inputs * Start mapping outputs * Save point #3 * Save point #4 * All API calls mapped * Save point #5 * Add task init and update risk score to float * Add msft strip and remove nexpose id * Save point #6 query search and api calls * Update output, successful call and outputs * Update docstrings and type hints * Save point #7 * Save point #8 * Update single line in query * filter results and status_id * query fixed * Condense results finished * Changes made to filter * Cacheing begin * Save point #9 * Save point #10 * Dockerfile restored and debugging statements * Get latest to get latest completed * Trigger + cacheing works * it works .. * Trigger working and doc strings added * Some prospector issues fixed * Prospector fixes * Version updated to 620 * Remove software update id * Removed risk score * Help MD fix etc * Remove risk score * Update help md again * Update dockerfile * Add asset group & cve input * Small dot updates plus verify method * Updated to paged resource request * Update to determine cache for resource request * Black formatting * Update doc strings and comments * Update single letter variables * Fix prospector * Add severity and cvss score input * Validator fix * Update to remove condense results * Remove hostname and ip input * Update spec file with corrections * Remove caching * Add dot get * Fix plugin validator * Update :fingerscrossed * [PLGN-634] InsightVM - Asset Search | JsonDecode Error (#2185) * Improved error handling ever so slightly * Changed single letter variables * Change error to data
cmcnally-r7
added a commit
that referenced
this pull request
Dec 14, 2023
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
rbowden-r7
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
joneill-r7
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
rbowden-r7
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
rbowden-r7
pushed a commit
that referenced
this pull request
Jan 3, 2024
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
ablakley-r7
pushed a commit
that referenced
this pull request
Jan 8, 2024
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
rbowden-r7
pushed a commit
that referenced
this pull request
Jan 8, 2024
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
igorski-r7
pushed a commit
that referenced
this pull request
Jan 8, 2024
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
rbowden-r7
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
igorski-r7
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
rbowden-r7
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Improved error handling ever so slightly * Changed single letter variables * Change error to data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
Asset Searchaction.PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobodyin theDockerfilewhen possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}insight-plugin validatewhich callsicon_validateto linthelp.mdFunctional Checklist
tests/directory created withinsight-plugin samplestests/$action_bad.jsoninsight-plugin run -T tests/example.json --debug --jqinsight-plugin run -T all --debug --jq(use PR format at end)insight-plugin run -R tests/example.json --debug --jqinsight-plugin run --debug --jq(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validateand make sure everything passesinsight-plugin run -A. For single action validation:insight-plugin run tests/{file}.json -Ainsight-plugin ... | pbcopy) and paste the output in a new post on this PR