Skip to content

Jira: Fix bug in "Get Comments", failing normalize_user in Jira Cloud #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrinehart-r7 merged 15 commits into from
Oct 5, 2021
Merged

Jira: Fix bug in "Get Comments", failing normalize_user in Jira Cloud #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a854f50
Add pass-thru is_cloud for normalize_user
ax-rpipkin Aug 27, 2021
0a188e3
Fix bug normalize_comment not receiving connection.is_cloud
ax-rpipkin Aug 27, 2021
7033466
Merge branch 'master' into bug/jira_cloud_get_comments_failure
mberezin-r7 Sep 3, 2021
6d42af2
bump version
ax-rpipkin Sep 7, 2021
30552e3
Merge branch 'bug/jira_cloud_get_comments_failure' of github.com:ax-r…
ax-rpipkin Sep 7, 2021
6440610
Updated version minor as previous Get Comments action only worked wit…
ax-rpipkin Sep 7, 2021
c59b66a
updated checksum with icon-plugin tool
ax-rpipkin Sep 7, 2021
dd19f2a
Merge branch 'master' into bug/jira_cloud_get_comments_failure
mrinehart-r7 Sep 9, 2021
8cb9234
Update help.md
mrinehart-r7 Sep 9, 2021
08a2111
Merge branch 'master' into bug/jira_cloud_get_comments_failure
pmara-r7 Sep 14, 2021
2bfc2dd
Merge branch 'master' into bug/jira_cloud_get_comments_failure
mrinehart-r7 Sep 15, 2021
4bd2490
Merge branch 'master' into bug/jira_cloud_get_comments_failure
pmara-r7 Sep 16, 2021
a5bb529
Merge branch 'master' into bug/jira_cloud_get_comments_failure
mberezin-r7 Oct 4, 2021
379e628
Regenerate checksum.
mberezin-r7 Oct 4, 2021
8d1b543
Add missing newline to help.md. Passing local validation.
mberezin-r7 Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/jira/.CHECKSUM
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"spec": "920ed91ee490c184d074e8c81f037c68",
"manifest": "e34d2e217c44d6ed8260591983f3271b",
"setup": "8d373e394c4694c13d32a7ab69350cf0",
"spec": "dfdafa425b7f25597bda967723b2d4ae",
"manifest": "189dfa93470e08aaebe8313f474f4dc7",
"setup": "53005391dcefb9bf8a39e1e2a23f354e",
"schemas": [
{
"identifier": "assign_issue/schema.py",
Expand Down
2 changes: 1 addition & 1 deletion plugins/jira/bin/komand_jira
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ from sys import argv

Name = "Jira"
Vendor = "rapid7"
Version = "6.1.1"
Version = "6.2.0"
Description = "Automate the creation, search and management of issues, users, and alerting for Jira Software, Jira Server, and Jira ServiceDesk"


Expand Down
1 change: 1 addition & 0 deletions plugins/jira/help.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,7 @@ _This plugin does not contain any troubleshooting information._

# Version History

* 6.2.0 - Fix issue in Get Comments actions where normalize_user is missing the is_cloud argument from client connection
* 6.1.1 - Fix issue where attachments added in tickets were empty
* 6.1.0 - Add Monitor Issues trigger | Update New Issue trigger to only trigger in case of recently created tickets | Change `required` property to false for `project` input in New Issue trigger | Fix issue in New Issue trigger to include all results that match JQL | Fix issue in New Issue trigger with retrieving attachments
* 6.0.8 - Fix issue where exception type was wrong in Create Issue
Expand Down
2 changes: 1 addition & 1 deletion plugins/jira/komand_jira/actions/get_comments/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def run(self, params={}):

comments = issue.fields.comment.comments or []

results = list(map(lambda comment: normalize_comment(comment, logger=self.logger), comments))
results = list(map(lambda comment: normalize_comment(comment, is_cloud=self.connection.is_cloud, logger=self.logger), comments))
results = insightconnect_plugin_runtime.helper.clean(results)

count = len(results)
Expand Down
4 changes: 2 additions & 2 deletions plugins/jira/komand_jira/util/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
from insightconnect_plugin_runtime.exceptions import PluginException


def normalize_comment(source, logger=logging.getLogger()):
def normalize_comment(source, is_cloud=False, logger=logging.getLogger()):
comment = source.raw
author = normalize_user(source.author, logger=logger)
author = normalize_user(source.author, is_cloud, logger)
comment["author"] = author
return comment

Expand Down
2 changes: 1 addition & 1 deletion plugins/jira/plugin.spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ vendor: rapid7
support: rapid7
status: []
description: Automate the creation, search and management of issues, users, and alerting for Jira Software, Jira Server, and Jira ServiceDesk
version: 6.1.1
version: 6.2.0
supported_versions: ["Jira Server 6.0", "Jira (Cloud)", "Jira ServiceDesk (Cloud)"]
resources:
source_url: https://github.com/rapid7/insightconnect-plugins/tree/master/plugins/jira
Expand Down
2 changes: 1 addition & 1 deletion plugins/jira/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@


setup(name="jira-rapid7-plugin",
version="6.1.1",
version="6.2.0",
description="Automate the creation, search and management of issues, users, and alerting for Jira Software, Jira Server, and Jira ServiceDesk",
author="rapid7",
author_email="",
Expand Down