Add support for Python 3.14#1049
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
gforsyth
added
improvement
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Looks great. As long as whoever reviews for cucim-python-codeowners is ok with bumping the scikit-image floor, I'm good with this.
If we want to retain support for older scikit-image versions, we could enforce the new, higher floor for only Python 3.14 (with if: statements in the recipe and environment markers in pyproject.toml).
gforsyth
force-pushed
the
python-3.14-rev3
branch
from
06ee6bc to
77cc6d1
Compare
gforsyth
force-pushed
the
python-3.14-rev3
branch
from
77cc6d1 to
583517d
Compare
| - libcucim ={{ version }} | ||
| - python | ||
| - scikit-image >=0.19.0,<0.25.0 | ||
| - scikit-image >=0.23.2,<0.27.0 |
There was a problem hiding this comment.
This was missed in PR: #1038
As noted in comment: #1038 (comment)
Hence the update to scikit-image's constraints here
There was a problem hiding this comment.
Thanks, @jakirkham ! I forgot about that and I couldn't figure out why this was showing up in the diff 😬
| @pytest.mark.xfail( | ||
| sys.version_info >= (3, 14), | ||
| reason="Fails on Python 3.14, see tracking issue: https://github.com/rapidsai/cucim/issues/1043", | ||
| ) | ||
| def test_read_random_region_cpu_memleak(testimg_tiff_stripe_4096x4096_256): |
|
/merge |
Followup to #1049 Now that rapidsai/shared-workflows#508 is merged in, we can point back at the `release/26.04` branch of `shared-workflows` Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - James Lamb (https://github.com/jameslamb) URL: #1052
5 participants
Supercedes #1033 where a
VERSIONfile check has been flummoxed by a bunch of rebases.Description
Contributes to rapidsai/build-planning#205
This PR adds support for Python 3.14.
Notes for Reviewers
This is part of ongoing work to add Python 3.14 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.14, from rapidsai/shared-workflows#508.
A follow-up PR will revert back to pointing at the
mainbranch ofshared-workflowsonce allRAPIDS repos have added Python 3.14 support.
This will fail until all dependencies have been updated to Python 3.14
CI here is expected to fail until all of this project's upstream dependencies support Python 3.14.
This can be merged whenever all CI jobs are passing.