Support nested types in lists::contains#10548
Merged
rapids-bot[bot] merged 206 commits intorapidsai:branch-22.10from Aug 22, 2022
Merged
Support nested types in lists::contains#10548rapids-bot[bot] merged 206 commits intorapidsai:branch-22.10from
lists::contains#10548rapids-bot[bot] merged 206 commits intorapidsai:branch-22.10from
Conversation
ttnghia
added
feature request
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com> # Conflicts: # cpp/src/lists/contains.cu
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
mythrocks
reviewed
Aug 15, 2022
mythrocks
reviewed
Aug 15, 2022
mythrocks
reviewed
Aug 15, 2022
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
bdice
requested changes
Aug 16, 2022
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
A few more comments -- I think I will approve when these are addressed. There's a lot going on in this PR and I've tried my best to make sense of it, but there's a lot of "patterning" with complex lambdas, boolean template dispatches, etc. I am struggling to find better recommendations but I don't think I can concretely identify what I would prefer in those cases, if anything, at this time.
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
bdice
approved these changes
Aug 22, 2022
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
One minor comment, otherwise LGTM.
cpp/tests/lists/contains_tests.cpp
Outdated
| auto const lists = [] { | ||
| auto offsets = indices_col{0, 4, 7, 10, 15, 18, 21, 24, 24, 28, 28}; | ||
| // clang-format off | ||
| auto data1 = tdata_col{0, 1, 2, 1, // |
Contributor
There was a problem hiding this comment.
Are the trailing // necessary if clang-format is already turned off in this section? I'd remove the trailing //.
Contributor
Author
|
Rerun tests. |
Contributor
Author
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
On some systems, CUDA compiler may have an issue such that it will throw unused variables warnings into your face if you use `if constexpr` with an `else` branch. Such warnings were reported due to a recent merged PR (#10548). This PR rewrites the `else` branch of the `if constexpr` in `lists/contains.cu` into a second `if constexpr` statement with opposite condition to avoid the warnings. Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - David Wendt (https://github.com/davidwendt) - Bradley Dice (https://github.com/bdice) - Mark Harris (https://github.com/harrism) URL: #11581
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the
lists::containsAPI to support nested types (lists + structs) with arbitrarily nested levels. As such,lists::containswill work with literally any type of input data.In addition, the related implementation has been significantly refactored to facilitate adding new implementation.
Closes #8958.
Depends on:
iterator.cuhand add fixed point support forscalar_optional_accessor#10999lists::contains#11019left_semi_anti_join,cudf::contains, and set operations #11037