Update distinct/unique_count to experimental::row hasher/comparator#12776
Merged
rapids-bot[bot] merged 26 commits intorapidsai:branch-23.04from Mar 7, 2023
Merged
Conversation
Co-authored-by: Nghia Truong <nghiatruong.vn@gmail.com>
divyegala
added
feature request
vyasr
requested changes
Feb 16, 2023
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
Couple of minor questions.
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
ttnghia
approved these changes
Feb 21, 2023
karthikeyann
reviewed
Mar 1, 2023
Contributor
karthikeyann
left a comment
karthikeyann
left a comment
There was a problem hiding this comment.
How are benchmarks impacted by this PR?
…action-row-hasher
Member
Author
There are no benchmarks for these algorithms |
vyasr
approved these changes
Mar 7, 2023
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
One minor question, otherwise LGTM. Is the plan to keep moving forward with these for now and investigate compile times when we can?
| rmm::exec_policy(stream), | ||
| thrust::counting_iterator<cudf::size_type>(0), | ||
| thrust::counting_iterator<cudf::size_type>(keys.num_rows()), | ||
| [comp] __device__(cudf::size_type i) { return (i == 0 or not comp(i, i - 1)); }); |
Contributor
There was a problem hiding this comment.
I assume that we can't capture the comparator by reference because it's a host object that needs to be copied to device for the lambda?
Member
Author
|
@vyasr and I followed up offline on his compile time question. |
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of #11844
Checklist
Compilation Times
distinct_count.cuThis PR: 3m8.392s
main: 1m37.576s
unique_count.cuThis PR: 13m8.858s
main: 8m21.900s