Support min and max aggregations for list type in groupby and reduction#13676
Merged
rapids-bot[bot] merged 22 commits intorapidsai:branch-23.08from Jul 12, 2023
Merged
Support min and max aggregations for list type in groupby and reduction#13676rapids-bot[bot] merged 22 commits intorapidsai:branch-23.08from
min and max aggregations for list type in groupby and reduction#13676rapids-bot[bot] merged 22 commits intorapidsai:branch-23.08from
Conversation
ttnghia
added
feature request
This was referenced Jul 7, 2023
ttnghia
changed the title
min and max aggregations for lists type in groupby and reductionmin and max aggregations for list type in groupby and reduction
ttnghia
commented
Jul 11, 2023
ttnghia
commented
Jul 11, 2023
divyegala
reviewed
Jul 11, 2023
Co-authored-by: Divye Gala <divyegala@gmail.com>
Co-authored-by: Divye Gala <divyegala@gmail.com>
Co-authored-by: Divye Gala <divyegala@gmail.com>
divyegala
approved these changes
Jul 11, 2023
mythrocks
reviewed
Jul 11, 2023
mythrocks
reviewed
Jul 12, 2023
mythrocks
reviewed
Jul 12, 2023
mythrocks
approved these changes
Jul 12, 2023
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
A couple of nitpicks. I appreciate the clarity in the code comments, and the test coverage.
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for list type in
minandmaxaggregations in groupby and reduction contexts.Closes #13667 and closes #10408.
Status:
compute-sanitizer.min/maxaggregations in groupby and reduction NVIDIA/spark-rapids#8689).