Skip to content

Improve distinct join with set retrieve#15636

Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.06from
PointKernel:improve-distinct-join
May 6, 2024
Merged

Improve distinct join with set retrieve#15636
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.06from
PointKernel:improve-distinct-join

Conversation

@PointKernel
Copy link
Copy Markdown
Member

@PointKernel PointKernel commented May 1, 2024

Description

This PR updates the distinct join to use static_set::retrieve instead of the custom device code.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 1, 2024
@PointKernel PointKernel requested a review from a team as a code owner May 1, 2024 23:04
@PointKernel PointKernel requested review from karthikeyann and shrshi May 1, 2024 23:04
@PointKernel PointKernel self-assigned this May 1, 2024
bdice
bdice approved these changes May 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PointKernel! This is nice cleanup.

davidwendt
davidwendt approved these changes May 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuco is awesome

ttnghia
ttnghia approved these changes May 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@PointKernel PointKernel added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 6, 2024
@PointKernel
Copy link
Copy Markdown
Member Author

PointKernel commented May 6, 2024

/merge

@rapids-bot rapids-bot bot merged commit bc3071e into rapidsai:branch-24.06 May 6, 2024
@PointKernel PointKernel deleted the improve-distinct-join branch May 6, 2024 22:12
@GregoryKimball GregoryKimball mentioned this pull request May 7, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@shrshi shrshi shrshi approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@davidwendt davidwendt davidwendt approved these changes

Assignees

@PointKernel PointKernel

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@PointKernel @bdice @karthikeyann @shrshi @ttnghia @mhaseeb123 @davidwendt