Refactor dictionary encoding in PQ writer to migrate to the new cuco::static_map#16541
Merged
rapids-bot[bot] merged 39 commits intorapidsai:branch-24.10from Aug 30, 2024
Merged
Conversation
cuco::legacy::static_map to cuco::static_mapcuco::static_map
PointKernel
reviewed
Aug 13, 2024
PointKernel
reviewed
Aug 13, 2024
mhaseeb123
commented
Aug 13, 2024
cuco::static_mapcuco::static_map
mhaseeb123
commented
Aug 20, 2024
mhaseeb123
commented
Aug 20, 2024
mhaseeb123
commented
Aug 20, 2024
Member
Author
|
/ok to test |
davidwendt
reviewed
Aug 20, 2024
3 tasks
Member
|
Redundant capacity issue is tracked via NVIDIA/cuCollections#581 |
PointKernel
reviewed
Aug 21, 2024
Member
Author
|
/ok to test |
PointKernel
approved these changes
Aug 26, 2024
Co-authored-by: Yunsong Wang <yunsongw@nvidia.com>
Member
Author
|
/ok to test |
davidwendt
approved these changes
Aug 29, 2024
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #12261. This PR refactors the dictionary encoding in Parquet writers to migrate from
cuco::legacy::static_maptocuco::static_mapto build the dictionaries.Performance Results
The changes result in +0.08% average speed improvement and +16.22% average memory footprint increase (stems from the adjusted sizes by
cuco::make_window_extentdue to prime gap) across the benchmark cases extended from #16591Currently, we do see a roughly 8% speed improvement in map insert and find kernels which is counteracted by the map init and map collect kernels as they have to process 16.22% more slots. With a cuco bump, the average speed improvement will increase from 0.08% to +3% and the memory footprint change will go back from 16.22% to +0%.
Hardware used for benchmarking
Checklist