Remove CUDA whole compilation ODR violations#16603
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.10from Aug 26, 2024
Merged
Remove CUDA whole compilation ODR violations#16603rapids-bot[bot] merged 5 commits intorapidsai:branch-24.10from
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.10from
Conversation
robertmaynard
added
bug
harrism
approved these changes
Aug 21, 2024
vyasr
approved these changes
Aug 22, 2024
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
IIUC this is basically just adding an extra level of indirection so that the kernels are only compiled once and hidden beneath a single C++ launch function that can be called in different TUs? If so, LGTM.
Contributor
Author
That is correct |
Contributor
Author
|
/merge |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CUDA whole compilation mode requires that all kernels are only launched from TUs that compile them. Previously libcudf would compile a subset of kernels in separate TUs from where they are launched.
To keep compile times ( and library size ) as low as possible I have introduced a single C++ function call between the original call site and the kernel launch. In testing this neglibile differences on compile time and binary size.
Checklist