Add parquet-sampling configuration options#19423
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.08from Jul 20, 2025
Merged
Add parquet-sampling configuration options#19423rapids-bot[bot] merged 8 commits intorapidsai:branch-25.08from
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.08from
Conversation
Contributor
TomAugspurger
left a comment
There was a problem hiding this comment.
Thanks. Could you also add update test_config_option_from_env in test_config.py to test out setting these via environment variables?
Member
Author
Good point - I updated |
TomAugspurger
approved these changes
Jul 18, 2025
Matt711
approved these changes
Jul 18, 2025
Member
Author
|
/merge |
Contributor
|
Failed to merge PR using squash strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #19389
Adds
max_footer_samplesandmax_row_group_samplesconfiguration options to control metadata/row-group sampling. Although these configuration options are only used by the streaming executor, it felt more natural to add these toParquetOptions(since they are definitely Parquet specific).Checklist