Clean up mixed join common utilities#20836
Merged
rapids-bot[bot] merged 9 commits intorapidsai:mainfrom Jan 6, 2026
Merged
Conversation
PointKernel
added
libcudf
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test cf2edc4 |
6 tasks
Member
Author
|
/ok to test 890ff7d |
kingcrimsontianyu
approved these changes
Dec 16, 2025
Contributor
kingcrimsontianyu
left a comment
kingcrimsontianyu
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the work!
davidwendt
approved these changes
Jan 5, 2026
Member
Author
|
/merge |
galipremsagar
pushed a commit
to galipremsagar/cudf
that referenced
this pull request
Jan 9, 2026
Contributes to rapidsai#19270 This is the first PR aimed at improving and tidying up the internal utilities used for joins. It focuses on mixed joins: several utilities specific to mixed joins were previously placed in the general join utilities header, and the mixed semi/anti join utilities were located in the standard mixed join header. This PR reorganizes those utilities into more appropriate locations and cleans up header inclusions across all join source files. Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - Tianyu Liu (https://github.com/kingcrimsontianyu) - David Wendt (https://github.com/davidwendt) URL: rapidsai#20836
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #19270
This is the first PR aimed at improving and tidying up the internal utilities used for joins. It focuses on mixed joins: several utilities specific to mixed joins were previously placed in the general join utilities header, and the mixed semi/anti join utilities were located in the standard mixed join header. This PR reorganizes those utilities into more appropriate locations and cleans up header inclusions across all join source files.
Checklist