Draft
Conversation
Replace device_memory_resource* with device_async_resource_ref across all C++ headers, sources, benchmarks, examples, and tests. In Cython .pxd declarations, change device_memory_resource *mr parameters to device_async_resource_ref mr (value type). In .pyx files, replace mr.get_mr() calls with mr.c_ref.value(). Remove cudf::set_current_device_resource (pointer-based) wrapper, keeping only the ref-based set_current_device_resource_ref. Update return types of set/reset_current_device_resource_ref to cuda::mr::any_resource<cuda::mr::device_accessible>. In host_memory.cpp, remove device_memory_resource inheritance from pinned_pool_with_fallback_memory_resource, remove the forward declaration workaround for rmm::mr::pool_memory_resource (no longer templated), and wrap non-copyable state in shared_ptr to satisfy the any_resource copyability requirement. Part of rapidsai/rmm#2011
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
libcudf
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device_memory_resource*withdevice_async_resource_refacross all C++ headers, sources, benchmarks, examples, and tests..pxddeclarations, changedevice_memory_resource *mrparameters todevice_async_resource_ref mr(value type). In.pyxfiles, replacemr.get_mr()calls withmr.c_ref.value().cudf::set_current_device_resource(pointer-based) wrapper, keeping only the ref-basedset_current_device_resource_ref. Update return types ofset/reset_current_device_resource_reftocuda::mr::any_resource<cuda::mr::device_accessible>.host_memory.cpp, removedevice_memory_resourceinheritance frompinned_pool_with_fallback_memory_resource, remove the forward declaration workaround forrmm::mr::pool_memory_resource(no longer templated), and wrap non-copyable state inshared_ptrto satisfy theany_resourcecopyability requirement.Part of rapidsai/rmm#2011