-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Parquet writer dictionary encoding refactor #8476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 76 commits into
rapidsai:branch-21.10
from
devavret:parquet-writer-dict-refactor
Aug 19, 2021
Merged
Changes from all commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
32dce41
Add make_zero_device_uvector_async
harrism d922868
device_vector->uvector in gather
harrism 10c8b38
zero->zeroed
harrism 404ddc4
uvector in dictionary
devavret dff6e5d
uvector in stats
devavret 48618ce
Merge remote-tracking branch 'harrism/fea-gather-uvector' into parque…
devavret 361878e
uvector in all remaining places in parquet writer
devavret edcd6d7
uvector in read parquet
devavret a838118
Use hostdevice_2dvector and spans for fragments
devavret 7b446ab
fragment update in stats
devavret 5685584
spans in frag stats
devavret a471bdb
2dvector for chunks part 1
devavret aa43df2
2d span for chunks
devavret f1639c4
flat span for chunk part 1
devavret 34952e0
chunks flat span part 2
devavret bf3bdd3
span for pages part 1
devavret bb169bb
Merge branch 'branch-0.20' into parquet-writer-spans
devavret 4a02435
spans for columndesc
devavret 89cc637
chunk span for dictionary
devavret 0ca82ea
spans for compression structs
devavret ab656d8
Clean up function arguments
devavret 08ab80b
small cleanup in span for chunk fragment
devavret 421e909
Merge branch 'branch-0.20' into parquet-writer-spans
devavret 920ba7b
Merge branch 'branch-0.20' into parquet-writer-spans
devavret 3c050bb
Merge branch 'branch-0.20' into parquet-writer-spans
devavret 765b166
review fix
devavret 9a2789f
Working insertion for 100 unique values
devavret 37e8952
Misc review fixes
devavret a02c749
Merge branch 'branch-0.20' into parquet-writer-spans
devavret b9f49c4
Put a pointer in the page struct to its corresponding comp_stat
devavret 90d3c7f
Clean up unnecessary arguments for comp_status
devavret b61dc48
Give chunk struct a pointer to its pages
devavret 36ed3ad
Remove start_page from last remaining kernel
devavret a65eef7
Merge branch 'parquet-writer-spans' into parquet-writer-dict-refactor
devavret 3dc3d44
Merge branch 'branch-0.20' into parquet-writer-dict-refactor
devavret 638b554
Fixed the issue with hash and initializer.
devavret ac2173e
Merge branch 'branch-0.20' into parquet-writer-dict-refactor
devavret f8febb3
tested large num uniq
devavret ad64143
Pull from cuco
devavret b223cc4
Add dict size counting and decision making
devavret 17acb35
Add dictionary compaction
devavret 3d3ea90
Get dictionary indices. Slow but hopefully working
devavret 8376ae4
Merge branch 'branch-21.06' into parquet-writer-dict-refactor
devavret 214b756
change get indices launch to 1blk/5000 rows from 1blk/ck
devavret 6d97224
tuned block sizes for dict insert and find kernels
devavret 0152f88
Plug new dict into encoder. works for int8 test
devavret b04fb7b
Disable dict for bool cols
devavret e3093d1
Fix bug where num_dict_entries is 0 so nbits is 32
devavret 5bc604e
Fix dict_index writing.
devavret 1939ce5
Merge branch 'branch-21.08' into parquet-writer-dict-refactor
devavret bda722f
Complete replacing old dict code with new
devavret 026ed8c
Clenup dict_data and dict_index
devavret 23d4346
Don't launch dict kernels for 0 chunks
devavret d8a701f
dict_rle_bits_plus1 -> dict_rle_bits
devavret 7fbd26b
Misc cleanups
devavret 0d2cb6f
dict code cleanups
devavret a62f7f3
Remove old dict code from initFrags
devavret 2e871ba
Completely remove old dict code
devavret cce3b8b
Documentation
devavret 67997b5
Replace copied cuco headers with cpm included repo
devavret f4afda4
Revert changes to benchmark and test code
devavret 9e8d666
Testing CI for deadlock
devavret 797ba36
Merge branch 'branch-21.10' into parquet-writer-dict-refactor
devavret ff8b885
Build breakage caused by merge
devavret bb07ded
Confirming that newest version fixes CI for pascal
devavret 15d15b4
Add missing syncthreads
devavret b401a5f
Fix for #8890
devavret 533ccab
Review cleanups
devavret cd375a0
Fix a potential bug in dictionary creation where loop exits before sy…
devavret c717e72
Cmake review changes
devavret 520cb84
More cmake review fixes
devavret 8b74b96
More cmake fix
devavret 487ffd3
no more camelCase
devavret 09d02b5
Review fixes
devavret 1f22996
MAX_DICT_SIZE was off by one
devavret 81be63f
Update cpp/src/io/parquet/chunk_dict.cu
devavret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| #============================================================================= | ||
| # Copyright (c) 2021, NVIDIA CORPORATION. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| #============================================================================= | ||
|
|
||
| function(find_and_configure_cucollections) | ||
|
|
||
| if(TARGET cuco::cuco) | ||
| return() | ||
| endif() | ||
|
|
||
| # Find or install cuCollections | ||
| CPMFindPackage(NAME cuco | ||
| GITHUB_REPOSITORY NVIDIA/cuCollections | ||
| GIT_TAG 0d602ae21ea4f38d23ed816aa948453d97b2ee4e | ||
| OPTIONS "BUILD_TESTS OFF" | ||
| "BUILD_BENCHMARKS OFF" | ||
| "BUILD_EXAMPLES OFF" | ||
| ) | ||
|
|
||
| set(CUCO_INCLUDE_DIR "${cuco_SOURCE_DIR}/include" PARENT_SCOPE) | ||
|
|
||
| # Make sure consumers of cudf can also see cuco::cuco target | ||
| fix_cmake_global_defaults(cuco::cuco) | ||
| endfunction() | ||
|
|
||
| find_and_configure_cucollections() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.