chore: skip DGL tests on Python 3.13#201
chore: skip DGL tests on Python 3.13#201rapids-bot[bot] merged 15 commits intorapidsai:branch-25.06from
Conversation
gforsyth
added
improvement
gforsyth
added
improvement
|
I modified |
| with: | ||
| # This selects "ARCH=amd64 + the latest supported Python + CUDA". | ||
| matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | ||
| # This selects "ARCH=amd64 + Python 3.12 + CUDA". |
There was a problem hiding this comment.
This would drop Python 3.10 and 3.11, which I don’t think we want? Just say “not 3.13” here.
There was a problem hiding this comment.
It was already dropping Python 3.10 and 3.11 with the max_by(.PY_VER) -- I'm just telling it to use 3.12 instead of the new max of 3.13
There was a problem hiding this comment.
Ahhhh I missed that this is a pure wheel. (See pure-wheel: true below). That's fine, then.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
| with: | ||
| # This selects "ARCH=amd64 + the latest supported Python + CUDA". | ||
| matrix_filter: map(select(.ARCH == "amd64")) | group_by(.CUDA_VER|split(".")|map(tonumber)|.[0]) | map(max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))])) | ||
| # This selects "ARCH=amd64 + Python 3.12 + CUDA". |
There was a problem hiding this comment.
Ahhhh I missed that this is a pure wheel. (See pure-wheel: true below). That's fine, then.
ci/build_wheel_cugraph-dgl.sh
Outdated
| set -euo pipefail | ||
|
|
||
| package_dir="python/cugraph-dgl" | ||
| if [ "$RAPIDS_PY_VERSION" != "3.13" ]; then |
There was a problem hiding this comment.
Shouldn't this be unreachable, because we skip the wheel build job for Python 3.13?
We also skip ARM but we don't have exceptions in the script for that. I would favor just leaving this script as-is and letting the filtering be done at the GHA workflow level.
The same applies to all bash scripts in this PR.
|
Removed the 3.13 branching stuff from all the bash scripts, ready for another look @bdice |
ci/test_python.sh
Outdated
| # bulk sampler IO tests (hangs in CI) | ||
|
|
||
| if [[ "${RUNNER_ARCH}" != "ARM64" ]]; then | ||
| if [[ "${RUNNER_ARCH}" != "ARM64" && "${RAPIDS_PY_VERSION}" != "3.13" ]]; then |
There was a problem hiding this comment.
Can we skip these with a matrix filter instead? I think currently these spin up a job (for ARM) that immediately ends. Let’s avoid that.
There was a problem hiding this comment.
No material changes. Please revert this file.
|
/merge |
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Gil for working on this! Also thanks Bradley and Alex for reviewing 🙏
Commented on one small change below that caught my eye
| if [[ "${PKG_CUDA_VER_MAJOR}" == "12" ]]; then | ||
| PYTORCH_CUDA_VER="121" | ||
| PYTORCH_CUDA_VER="121" | ||
| else | ||
| PYTORCH_CUDA_VER=$PKG_CUDA_VER | ||
| PYTORCH_CUDA_VER=$PKG_CUDA_VER | ||
| fi |
There was a problem hiding this comment.
It looks like this dedent change snuck in
4 participants
dgldoesn't have Python 3.13 builds and it's also going to be dropped in 25.08, so we just aren't including it in the 3.13 migration.Part of issue: rapidsai/build-planning#120