Replace legacy SCC with the new SCC implementation and SCC performance improvements#5469
Open
seunghwak wants to merge 46 commits intorapidsai:mainfrom
Open
Replace legacy SCC with the new SCC implementation and SCC performance improvements#5469seunghwak wants to merge 46 commits intorapidsai:mainfrom
seunghwak wants to merge 46 commits intorapidsai:mainfrom
Conversation
seunghwak
added
improvement
seunghwak
changed the title
seunghwak
added
breaking
jameslamb
approved these changes
Apr 2, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Looks ok to me from a ci-codeowners perspective, it's ok to bump up the max allowed binary size a bit for now.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
/ok to test 717b468 |
rlratzel
approved these changes
Apr 3, 2026
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
The changes themselves LGTM, but I have a minor concern about the breaking change.
We could consider creating a backwards-compatible API that calls the new SCC with a deprecation warning, but I don't think any/many users will have a problem with this. I know nx-cugraph will need to be updated, but we don't need a deprecation warning for that.
…er and a transform iterator as a value iterator in thrust::reduce_by_key (this is failing on RTX Pro 6000)
Contributor
Author
|
/ok to test 80dd3ef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace legacy SCC with the new SCC implementation.
In addition, this code adds chain removal logic (a chain of in-degree 1 out-degree 1 vertices) in peeling out trivial singleton SCC vertices. The chain removal is based on pointer jumping and significantly reduces the number of iterations in recursively removing 0 in-degree or 0 out-degree vertices.
Breaking as the legacy SCC is removed.