Draft
Conversation
Replace removed rmm::mr::device_memory_resource base class, owning_wrapper, shared_ptr-based resource management, and deprecated per-device resource APIs with CCCL-native memory resource types: value-typed resources, cuda::mr::any_resource for owning type-erased storage, and rmm::device_async_resource_ref for non-owning references.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rmm::mr::device_memory_resourcebase class,owning_wrapper,shared_ptr-based resource management, and deprecated per-device resource APIs with CCCL-native memory resource typescuda::mr::any_resource<cuda::mr::device_accessible>for owning type-erased storage,rmm::device_async_resource_reffor non-owning references, and value-typed resources (cuda_memory_resource,pinned_host_memory_resource)raft::handle_tconstructor calls (handle only accepts stream + stream_pool)Files changed (15)
Headers:
algorithms.hpp,dendrogram.hpp,legacy/graph.hpp,legacy/functions.hpp:get_current_device_resource()→get_current_device_resource_ref()host_staging_buffer_manager.hpp: Removeowning_wrapper, usepool_memory_resourcedirectly viastd::optional, acceptpinned_host_memory_resourceby valuelarge_buffer_manager.hpp: Storepinned_host_memory_resourceby value (notshared_ptr), returndevice_async_resource_reffromget()mtmg/resource_manager.hpp: Usecuda::mr::any_resource<device_accessible>instead ofshared_ptr<device_memory_resource>, useset_per_device_resource_ref, remove MR arg fromraft::handle_tTests:
base_fixture.hpp: Returnany_resourcefromcreate_memory_resource(), use value-typed resources,set_current_device_resource_refmulti_node_threaded_test.cpp:set_current_device_resource_ref(resource)mg_graph500_bfs_test.cu:pinned_mr_asoptional<pinned_host_memory_resource>value typemg_graph500_sssp_test.cu:pinned_memory_resource→pinned_host_memory_resourcevalue typeExamples:
cuda_memory_resource,set_current_device_resource_ref, remove MR from handle constructor