Store any_resource in device_uvector_policy#2917
Closed
bdice wants to merge 2 commits intorapidsai:mainfrom
Closed
Store any_resource in device_uvector_policy#2917bdice wants to merge 2 commits intorapidsai:mainfrom
bdice wants to merge 2 commits intorapidsai:mainfrom
Conversation
Change device_uvector_policy::mr_ from device_async_resource_ref to cuda::mr::any_resource<cuda::mr::device_accessible>. This ensures the container policy owns its memory resource, preventing use-after-free if the original resource is destroyed while the policy still exists.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
41 tasks
bdice
added
feature request
Contributor
Author
|
Closing — superseded by #2996, which includes this change as part of the full RMM CCCL memory resource migration (rapidsai/rmm#2011). |
github-project-automation
bot
moved this from In Progress
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of rapidsai/rmm#2011.
Depends on rapidsai/rmm#2200.
Change
device_uvector_policy::mr_fromdevice_async_resource_reftocuda::mr::any_resource<cuda::mr::device_accessible>.This ensures the container policy owns its memory resource, preventing use-after-free if the original resource is destroyed while the policy still exists.