Skip to content

Remove owning_wrapper, no longer necessary after CCCL shared_resource adoption #2285

@bdice

Description

@bdice

As part of #2011 (Memory Resource Handling), all adaptors have been converted to the cuda::shared_resource design. Each adaptor now stores its upstream as an owning cuda::mr::any_resource<cuda::mr::device_accessible>, so upstream lifetime is managed directly by the adaptor itself.

owning_wrapper was introduced in PR #444 to help users manage the lifetime of upstream resources passed to adaptors. With the shared_resource conversion complete, owning_wrapper is no longer necessary — the problem it solved no longer exists.

The only active consumer of owning_wrapper is adaptor_tests.cpp. Three benchmark files and mr_ref_test.hpp have stale #include directives with no actual usage.

Tasks

  • Delete cpp/include/rmm/mr/owning_wrapper.hpp
  • Remove stale #include <rmm/mr/owning_wrapper.hpp> from benchmark and test files
  • Remove owning_wrapper from the typed test suite in adaptor_tests.cpp

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions