fix: qwen3.5-plus-kv-cache.ipynb to use KVCache#981
Merged
rasbt merged 1 commit intorasbt:mainfrom Mar 21, 2026
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Owner
|
Arg, must have forgotten to update that cell. Good catch, and thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Sebastian,
The Qwen3.5 with KVCache notebook was actually not using KVcache because it wasn't instantiated/used in
generate_text_basic_stream.We can see the trace being the same as the Qwen3.5 (no cache) notebook (which implies kvcache couldn't have been used):
~
Generation speed: 9.00 tokens/secAfter fix:
~
Generation speed: 15.16 tokens/secand test passed.