Enable additional mul_mat tests and add tensor data saving function#74
Closed
zhaixuejun1993 wants to merge 1 commit intoravi9:masterfrom
Closed
Enable additional mul_mat tests and add tensor data saving function#74zhaixuejun1993 wants to merge 1 commit intoravi9:masterfrom
zhaixuejun1993 wants to merge 1 commit intoravi9:masterfrom
Conversation
wine99
reviewed
Mar 20, 2026
| infer_request->set_input_tensor(i, input_tensor); | ||
| } | ||
|
|
||
| // TODO: Need to check why set_output_tensor() doesn't work in naive mode. For now, we will create output tensors after infer() and copy data back to ggml tensors. |
Collaborator
There was a problem hiding this comment.
can you update the comments here since we have figured out the reason of failing. otherwise lgtm. you can merge by yourself later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes to the OpenVINO integration in the
ggmllibrary, focusing on tensor handling, operation support, and utility enhancements. The most important changes include fixing tensor output handling in naive compute mode, improving permute operation translation, and adding a utility for saving tensor data to text files.Tensor output handling and utilities:
naive_computeby copying data directly from the OpenVINO output tensor to theggml_tensorafter inference, instead of relying onset_output_tensor, which currently does not work in naive mode.save_ggml_tensor_data_to_txtfor exporting tensor data to a text file, supporting multiple tensor types. Declaration added toutils.h. [1] [2]Operation support and translation:
permute.cppby dynamically constructing the permutation vector from operation parameters if available, allowing more flexible permute handling.is_op_unsupported_case, enabling permute operations to be processed by OpenVINO.General improvements:
<vector>inpermute.cppto support dynamic permutation vector construction.<fstream>inutils.cppto support file output in the new tensor saving utility.…buggingMake sure to read the contributing guidelines before submitting a PR