-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Description
Problem Statement
Throughout the Ray Serve codebase, we create various wrapper classes(like ASGIIngressWrapper, TaskConsumerWrapper, etc.) around the user-defined Deployment class . When these wrappers are created, they have their own metadata properties like name, module, and doc.
If we are not careful, downstream logic in ray-serve might introspect the wrapper class for this metadata instead of the original user-defined class. This can lead to unintentional behavior and confusing outcomes for the user.
Expected Behavior
Ray Serve should always prioritize and use the metadata ( name, module, doc, etc.) from the original, user-defined Deployment class. Our internal wrapper classes should be transparent and correctly propagate the original class's metadata.
Action Required
This issue is to track an audit and verification of our internal wrapper class patterns. We need to:
- Identify all places in ray-serve where we create a wrapper class (or function) on top of a user's Deployment class.
- Verify that for each wrapper, the critical metadata (name, module, doc, etc...) from the original class is correctly transferred to, or preserved on, the wrapper.
- Fix any instances where the wrapper's metadata is used instead of the user's.