Blocking asyncio get warning should be logger.warn not logger.debug#11141
Merged
ericl merged 2 commits intoray-project:masterfrom Sep 30, 2020
Merged
Blocking asyncio get warning should be logger.warn not logger.debug#11141ericl merged 2 commits intoray-project:masterfrom
ericl merged 2 commits intoray-project:masterfrom
Conversation
rkooo567
approved these changes
Sep 30, 2020
edoakes
approved these changes
Sep 30, 2020
Collaborator
edoakes
left a comment
edoakes
left a comment
There was a problem hiding this comment.
I'm a little bit conflicted about this because there are times when you may want to use ray.get() instead of await to avoid yielding the event loop, but I guess in that case you should probably just be using a lock to protect the critical section instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just ran into this issue today; took a while to figure out why things were blocking.