Skip to content

[Data] Disable Limit Pushdown rule in new execution plan optimizer #36831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulchen merged 1 commit into from
Jun 27, 2023
Merged

[Data] Disable Limit Pushdown rule in new execution plan optimizer #36831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/ray/data/_internal/logical/optimizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
OperatorFusionRule,
ReorderRandomizeBlocksRule,
)
from ray.data._internal.logical.rules.limit_pushdown import LimitPushdownRule
from ray.data._internal.planner.planner import Planner


Expand All @@ -19,7 +18,10 @@ class LogicalOptimizer(Optimizer):

@property
def rules(self) -> List[Rule]:
return [ReorderRandomizeBlocksRule(), LimitPushdownRule()]
# TODO(scottjlee): add back LimitPushdownRule once we
# enforce number of input/output rows remains the same
# for Map/MapBatches ops.
return [ReorderRandomizeBlocksRule()]


class PhysicalOptimizer(Optimizer):
Expand Down
4 changes: 4 additions & 0 deletions python/ray/data/tests/test_execution_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,10 @@ def test_from_torch_e2e(ray_start_regular_shared, enable_optimizer, tmp_path):
_check_usage_record(["FromItems"])


@pytest.mark.skip(
reason="Limit pushdown currently disabled, see "
"https://github.com/ray-project/ray/issues/36295"
)
def test_limit_pushdown(ray_start_regular_shared, enable_optimizer):
def f1(x):
return x
Expand Down