[data] refactor download expression to use inheritance from AbstractOneToOne#56294
Merged
bveeramani merged 2 commits intoray-project:masterfrom Sep 5, 2025
Merged
Conversation
Contributor
Author
|
Kicked off release test build to test it here. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the Download logical operator to inherit from AbstractOneToOne instead of AbstractMap. This change is logical and improves the code's structure. Additionally, this refactoring also addresses a minor performance inefficiency by switching to TaskPoolStrategy for the stateless download portion of the operation. The changes are well-implemented. I have one suggestion to improve documentation.
Comment on lines
+91
to
+104
| def __init__( | ||
| self, | ||
| input_op: LogicalOperator, | ||
| uri_column_name: str, | ||
| output_bytes_column_name: str, | ||
| ray_remote_args: Optional[Dict[str, Any]] = None, | ||
| ): | ||
| super().__init__( | ||
| "Download", | ||
| input_op, | ||
| ) | ||
| self._uri_column_name = uri_column_name | ||
| self._output_bytes_column_name = output_bytes_column_name | ||
| self._ray_remote_args = ray_remote_args or {} |
Contributor
There was a problem hiding this comment.
To improve code clarity and maintainability, consider adding a docstring to the __init__ method. This would help developers understand the purpose of its parameters without needing to inspect the implementation details.
def __init__(
self,
input_op: LogicalOperator,
uri_column_name: str,
output_bytes_column_name: str,
ray_remote_args: Optional[Dict[str, Any]] = None,
):
"""Initialize the Download operator.
Args:
input_op: The upstream logical operator.
uri_column_name: The name of the column containing the URIs to download.
output_bytes_column_name: The name of the column to store the downloaded bytes.
ray_remote_args: Ray remote arguments for the download tasks.
"""
super().__init__(
"Download",
input_op,
)
self._uri_column_name = uri_column_name
self._output_bytes_column_name = output_bytes_column_name
self._ray_remote_args = ray_remote_args or {}
bveeramani
approved these changes
Sep 5, 2025
Member
bveeramani
left a comment
bveeramani
left a comment
There was a problem hiding this comment.
LGTM assuming no regression
Comment on lines
+106
to
+107
| def can_modify_num_rows(self) -> bool: | ||
| return False |
Member
There was a problem hiding this comment.
Doesn't this modify the number of rows? Like, you pass in a URI for a CSV, and then possibly get many rows?
Contributor
Author
There was a problem hiding this comment.
I think it will depend on our implementation of the decode API. Right now every row will return the bytes of the uri, if we allow the decode function to return multiple rows we will need to handle that separately. For now, I think it is most correct to leave this as is.
python/ray/data/_internal/logical/operators/one_to_one_operator.py
Outdated
Show resolved
Hide resolved
…r.py Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Matthew Owen <omatthew98@berkeley.edu>
Contributor
Author
Release test results: |
sampan-s-nayak
pushed a commit
to sampan-s-nayak/ray
that referenced
this pull request
Sep 8, 2025
…OneToOne` (ray-project#56294) ## Why are these changes needed? `Download` logical operator isn't really a map, we should use `AbstractOneToOne` as the base class instead. <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Matthew Owen <mowen@anyscale.com> Signed-off-by: Matthew Owen <omatthew98@berkeley.edu> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: sampan <sampan@anyscale.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
…OneToOne` (ray-project#56294) ## Why are these changes needed? `Download` logical operator isn't really a map, we should use `AbstractOneToOne` as the base class instead. <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Matthew Owen <mowen@anyscale.com> Signed-off-by: Matthew Owen <omatthew98@berkeley.edu> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
wyhong3103
pushed a commit
to wyhong3103/ray
that referenced
this pull request
Sep 12, 2025
…OneToOne` (ray-project#56294) ## Why are these changes needed? `Download` logical operator isn't really a map, we should use `AbstractOneToOne` as the base class instead. <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Matthew Owen <mowen@anyscale.com> Signed-off-by: Matthew Owen <omatthew98@berkeley.edu> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
ZacAttack
pushed a commit
to ZacAttack/ray
that referenced
this pull request
Sep 24, 2025
…OneToOne` (ray-project#56294) ## Why are these changes needed? `Download` logical operator isn't really a map, we should use `AbstractOneToOne` as the base class instead. <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Matthew Owen <mowen@anyscale.com> Signed-off-by: Matthew Owen <omatthew98@berkeley.edu> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: zac <zac@anyscale.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
…OneToOne` (#56294) ## Why are these changes needed? `Download` logical operator isn't really a map, we should use `AbstractOneToOne` as the base class instead. <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Matthew Owen <mowen@anyscale.com> Signed-off-by: Matthew Owen <omatthew98@berkeley.edu> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…OneToOne` (ray-project#56294) ## Why are these changes needed? `Download` logical operator isn't really a map, we should use `AbstractOneToOne` as the base class instead. <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Matthew Owen <mowen@anyscale.com> Signed-off-by: Matthew Owen <omatthew98@berkeley.edu> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Downloadlogical operator isn't really a map, we should useAbstractOneToOneas the base class instead.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.