[Data] Support SaveMode for more write operations#57946
Merged
bveeramani merged 1 commit intoray-project:masterfrom Oct 21, 2025
Merged
[Data] Support SaveMode for more write operations#57946bveeramani merged 1 commit intoray-project:masterfrom
SaveMode for more write operations#57946bveeramani merged 1 commit intoray-project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly extends SaveMode support to write_tfrecords, write_webdataset, and write_numpy operations by passing the mode parameter to their respective datasinks. The implementation is straightforward and consistent with existing write operations in the dataset API. My main feedback is the lack of automated tests for this new functionality. While the PR description mentions manual verification, adding automated tests is crucial for long-term maintainability and to prevent regressions. I've added a specific comment regarding this.
Member
Author
|
@bveeramani PTAL! Thank you in advance! |
ray-gardener
bot
added
data
bveeramani
approved these changes
Oct 21, 2025
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
## Description See ray-project#57924 ## Related issues Fixes ray-project#57924 ## Additional information - [x] Verify by manual testing -> confirmed with example using `write_numpy` Signed-off-by: kyuds <kyuseung1016@gmail.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
## Description See ray-project#57924 ## Related issues Fixes ray-project#57924 ## Additional information - [x] Verify by manual testing -> confirmed with example using `write_numpy` Signed-off-by: kyuds <kyuseung1016@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
## Description See ray-project#57924 ## Related issues Fixes ray-project#57924 ## Additional information - [x] Verify by manual testing -> confirmed with example using `write_numpy` Signed-off-by: kyuds <kyuseung1016@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Blaze-DSP
pushed a commit
to Blaze-DSP/ray
that referenced
this pull request
Dec 18, 2025
## Description See ray-project#57924 ## Related issues Fixes ray-project#57924 ## Additional information - [x] Verify by manual testing -> confirmed with example using `write_numpy` Signed-off-by: kyuds <kyuseung1016@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
## Description See ray-project#57924 ## Related issues Fixes ray-project#57924 ## Additional information - [x] Verify by manual testing -> confirmed with example using `write_numpy` Signed-off-by: kyuds <kyuseung1016@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #57924
Related issues
Fixes #57924
Additional information
write_numpy