Skip to content

[Serve][7/n] Add long poll metrics#59246

Merged
abrarsheikh merged 2 commits intomasterfrom
59218-abrar-long
Dec 18, 2025
Merged

[Serve][7/n] Add long poll metrics#59246
abrarsheikh merged 2 commits intomasterfrom
59218-abrar-long

Conversation

@abrarsheikh
Copy link
Contributor

fixes #59218

Signed-off-by: abrar <abrar@anyscale.com>
@abrarsheikh abrarsheikh added the go add ONLY when ready to merge, run all tests label Dec 7, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds metrics for the long poll mechanism, including end-to-end propagation latency and the number of pending clients. The changes look good and are well-tested. I've suggested a couple of minor improvements to increase the accuracy of the latency measurements by moving the timestamp acquisition inside the processing loops. Overall, this is a great addition for monitoring and observability.

@abrarsheikh abrarsheikh marked this pull request as ready for review December 17, 2025 01:23
@abrarsheikh abrarsheikh requested review from a team as code owners December 17, 2025 01:23
@ray-gardener ray-gardener bot added serve Ray Serve Related Issue observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling labels Dec 17, 2025
@abrarsheikh abrarsheikh merged commit e7ac0ee into master Dec 18, 2025
6 checks passed
@abrarsheikh abrarsheikh deleted the 59218-abrar-long branch December 18, 2025 00:34
zzchun pushed a commit to zzchun/ray that referenced this pull request Dec 18, 2025
fixes ray-project#59218

Signed-off-by: abrar <abrar@anyscale.com>
Yicheng-Lu-llll pushed a commit to Yicheng-Lu-llll/ray that referenced this pull request Dec 22, 2025
fixes ray-project#59218

Signed-off-by: abrar <abrar@anyscale.com>
peterxcli pushed a commit to peterxcli/ray that referenced this pull request Feb 25, 2026
fixes ray-project#59218

Signed-off-by: abrar <abrar@anyscale.com>
Signed-off-by: peterxcli <peterxcli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Serve] add debugging metrics to ray serve

2 participants