[train] rename ScalingConfig.bundle_label_selector to label_selector#59414
Merged
matthewdeng merged 1 commit intoray-project:masterfrom Dec 13, 2025
Merged
[train] rename ScalingConfig.bundle_label_selector to label_selector#59414matthewdeng merged 1 commit intoray-project:masterfrom
matthewdeng merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a clean refactoring that renames ScalingConfig.bundle_label_selector to ScalingConfig.label_selector for a better API. The changes are consistent across all modified files, including configurations, internal logic, and tests. I've reviewed the changes and they seem correct and well-implemented. I have one minor suggestion to improve the parameter name in a test function for better clarity and consistency with the refactoring.
Yicheng-Lu-llll
pushed a commit
to Yicheng-Lu-llll/ray
that referenced
this pull request
Dec 22, 2025
…ay-project#59414) ## Description Rename `ScalingConfig.bundle_label_selector` to `ScalingConfig.label_selector` for a cleaner API. This matches the `@ray.remote` API, as opposed to the `PlacementGroup` API which uses `bundle_label_selector`. ## Related issues API was introduced in ray-project#58845. ## Additional information This change is technically backwards incompatible, but `bundle_label_selector` was just introduced and not part of any minor version releases yet. Also made the same changes to `WorkerGroupContext`, and renamed local variables in `TrainController` and `TPUReservationCallback` Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…ay-project#59414) ## Description Rename `ScalingConfig.bundle_label_selector` to `ScalingConfig.label_selector` for a cleaner API. This matches the `@ray.remote` API, as opposed to the `PlacementGroup` API which uses `bundle_label_selector`. ## Related issues API was introduced in ray-project#58845. ## Additional information This change is technically backwards incompatible, but `bundle_label_selector` was just introduced and not part of any minor version releases yet. Also made the same changes to `WorkerGroupContext`, and renamed local variables in `TrainController` and `TPUReservationCallback` Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename
ScalingConfig.bundle_label_selectortoScalingConfig.label_selectorfor a cleaner API.This matches the
@ray.remoteAPI, as opposed to thePlacementGroupAPI which usesbundle_label_selector.Related issues
API was introduced in #58845.
Additional information
This change is technically backwards incompatible, but
bundle_label_selectorwas just introduced and not part of any minor version releases yet.Also made the same changes to
WorkerGroupContext, and renamed local variables inTrainControllerandTPUReservationCallback