[train] Rename DatasetsSetupCallback to DatasetsCallback#59423
Merged
matthewdeng merged 1 commit intoray-project:masterfrom Dec 18, 2025
Merged
[train] Rename DatasetsSetupCallback to DatasetsCallback#59423matthewdeng merged 1 commit intoray-project:masterfrom
matthewdeng merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames DatasetsSetupCallback to DatasetsCallback to better reflect its expanded responsibilities, which now include resource cleanup logic beyond just initial setup. The change is a straightforward refactoring and has been applied consistently across all relevant files, including imports, class definitions, instantiations, and documentation. The new name improves clarity and aligns better with the callback's behavior. The changes are correct and well-executed.
TimothySeah
approved these changes
Dec 17, 2025
Yicheng-Lu-llll
pushed a commit
to Yicheng-Lu-llll/ray
that referenced
this pull request
Dec 22, 2025
…#59423) PR ray-project#58325 adds shutdown and abort hooks to enhance resource-cleanup logic in DatasetsSetupCallback, the callback’s responsibilities have expanded beyond initial setup. Accordingly, this PR renames it to DatasetsCallback for better alignment with its behavior. Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…#59423) PR ray-project#58325 adds shutdown and abort hooks to enhance resource-cleanup logic in DatasetsSetupCallback, the callback’s responsibilities have expanded beyond initial setup. Accordingly, this PR renames it to DatasetsCallback for better alignment with its behavior. Signed-off-by: JasonLi1909 <jasli1909@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #58325 adds shutdown and abort hooks to enhance resource-cleanup logic in DatasetsSetupCallback, the callback’s responsibilities have expanded beyond initial setup. Accordingly, this PR renames it to DatasetsCallback for better alignment with its behavior.